[release/6.0-rc1] Reliability improvement for input date E2E tests#35616
Merged
Pilchie merged 5 commits intorelease/6.0-rc1from Aug 24, 2021
Merged
[release/6.0-rc1] Reliability improvement for input date E2E tests#35616Pilchie merged 5 commits intorelease/6.0-rc1from
Pilchie merged 5 commits intorelease/6.0-rc1from
Conversation
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
ghost
added
the
SteveSandersonMS
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
TanayParikh
approved these changes
Aug 23, 2021
Member
|
Thanks Tanay! @pranavkm @javiercn @TanayParikh Would any of you be able to merge this backport PR if/when it gets shiproom approval? |
Contributor
Sure thing! |
Member
|
Test-only changes are tell-mode, so I'll go ahead and merge. |
Pilchie
added
tell-mode
wtgodbe
added a commit
that referenced
this pull request
Aug 24, 2021
* Update dependencies from https://github.com/dotnet/efcore build 20210821.6 (#35617) Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design From Version 6.0.0-rc.1.21420.45 -> To Version 6.0.0-rc.1.21421.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update docker container to mcr (#35630) Co-authored-by: Brennan <brecon@microsoft.com> * [release/6.0-rc1] Update dependencies from dotnet/runtime dotnet/efcore (#35634) [release/6.0-rc1] Update dependencies from dotnet/runtime dotnet/efcore * [release/6.0-rc1] HTTP/3: Response drain timeout (#35492) - backport of #35322 to release/6.0-rc1 * [release/6.0-rc1] Reliability improvement for input date E2E tests (#35616) * Reliability improvement for input date E2E tests * Avoid "collection was modified" error in CircuitGracefulTerminationTests * Avoid timing issues in CanFocusDuringOnAfterRenderAsyncWithFocusInEvent * Update src/Components/test/E2ETest/Tests/FormsTest.cs Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Remove notes from earlier Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Minimal APIs naming cleanup * Add Support for `DateOnly` & `TimeOnly` for `SupplyParameterFromQuery` Fixes: #35525 API Proposal: #35567 * Add FailureReasons (#35425) * Add support for Results extension point Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Brennan <brecon@microsoft.com> Co-authored-by: James Newton-King <james@newtonking.com> Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> Co-authored-by: Stephen Halter <halter73@gmail.com> Co-authored-by: Tanay Parikh <taparik@microsoft.com> Co-authored-by: Hao Kung <HaoK@users.noreply.github.com> Co-authored-by: Safia Abdalla <safia@microsoft.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #35505 to release/6.0-rc1
/cc @SteveSandersonMS
Description
With these changes, the components E2E tests have passed 100% every time in an Azure VM (based on 14 runs since I did these changes). This doesn't prove there isn't still some even-more-rarely-failing issue, but it's at least getting us closer.
I'm still not promising anything about reliability in CI. That's next on the list to look into. The work so far is exclusively about making it reliable in a controlled environment (a Azure VM, not CI).
Customer Impact
Doesn't affect customers, but helps us to have fewer build issues.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
Justification: it's test-only. No product code changes. It can't even fail the build since we've made the components e2e test job nonblocking for the build.
Verification
Packaging changes reviewed?
Addresses [issue number]
N/a