Apply API feedback for authorization failure #35620
Merged
Tratcher merged 3 commits intodotnet:haok/rc1from Aug 23, 2021
Merged
Apply API feedback for authorization failure #35620Tratcher merged 3 commits intodotnet:haok/rc1from
Tratcher merged 3 commits intodotnet:haok/rc1from
Conversation
ghost
added
area-auth
Tratcher
approved these changes
Aug 23, 2021
Comment on lines
+42
to
+53
| /// <summary> | ||
| /// Calls Fail and stores the failure reasons for future reference. Can be called multiple times. | ||
| /// </summary> | ||
| /// <param name="reasons">The reasons of failure</param> | ||
| /// <returns>The failure.</returns> | ||
| public static AuthorizationFailure ExplicitFail(IEnumerable<AuthorizationFailureReason> reasons) | ||
| => new AuthorizationFailure | ||
| { | ||
| FailCalled = true, | ||
| FailureReasons = reasons | ||
| }; | ||
|
|
Member
There was a problem hiding this comment.
You can remove this overload, it was outdated in the review. The new overload is the following one named Failed.
Member
|
Once updated and merged, please cherry pick to the |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#35319 (comment)
/cc @Tratcher