Update docker container to mcr#35623
Conversation
ghost
added
the
area-infrastructure
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Why not build 'main' w/ a more recent Docker image❔
No clue what this is doing, and I don't really care, just want to unblock our builds with the least amount of churn. Feel free to make a new PR after this goes in to fix it if it needs fixing. |
It's running a build to create bionic installers in the given Docker file. Given that, we should have updated the image as we change major / minor SDK versions because requirements (build-deps) change over time. See aspnetcore/.azure/pipelines/ci.yml Lines 428 to 439 in 64dca63 Note we'll need this change in every branch that uses |
|
/backport to release/6.0-rc1 |
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1160403237 |
|
@BrennanConroy by "everywhere" I unfortunately meant 'release/3.1' and 'release/5.0' too. There may also be a reference to this file in 'release/2.1' but I haven't looked (yet). |
|
Yeah I understand, but those aren't important branches today |
|
Agree on importance but I'd rather we confirm 3.1 and 5.0 builds will work when the time comes soon. |
|
That is, your point is really about urgency versus importance and this is important enough to avoid leaving it to the last minute. |
|
/backport to release/3.1 |
|
Started backporting to release/3.1: https://github.com/dotnet/aspnetcore/actions/runs/1160492572 |
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/1160493117 |
2 participants
Context: https://devblogs.microsoft.com/dotnet/net-core-2-1-container-images-will-be-deleted-from-docker-hub/