Skip to content

<TargetFrameworks /> -> <TargetFramework />#36727

Merged
dougbu merged 7 commits intomainfrom
dougbu/less.frameworksss
Sep 22, 2021
Merged

<TargetFrameworks /> -> <TargetFramework />#36727
dougbu merged 7 commits intomainfrom
dougbu/less.frameworksss

Conversation

@dougbu
Copy link
Copy Markdown
Contributor

@dougbu dougbu commented Sep 19, 2021

  • avoid useless transitions to inner builds

@dougbu
<TargetFrameworks /> -> <TargetFramework />
6bc2c7f 
- avoid useless transitions to inner builds
@dougbu dougbu requested review from a team and sebastienros September 19, 2021 18:39
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 19, 2021
@dougbu
Copy link
Copy Markdown
Contributor Author

dougbu commented Sep 19, 2021

  • avoid useless transitions to inner builds

@rainersigwald will this impact build performance at all❔

@dougbu
Remove unnecessary Condition
db84a61 
- project builds only w/ `$(DefaultNetCoreTargetFramework)`
@rainersigwald
Copy link
Copy Markdown
Member

rainersigwald commented Sep 20, 2021

will this impact build performance at all❔

Yes, but you might not notice.

Specifically, only one evaluation per project is required now, where before you were using two. Evaluation time is nontrivial but is not usually a huge component of build time.

dougbu
dougbu commented Sep 20, 2021
View reviewed changes
Comment thread src/Middleware/ConcurrencyLimiter/sample/ConcurrencyLimiterSample.csproj
Comment thread src/Mvc/perf/benchmarkapps/BasicApi/BasicApi.csproj Outdated
dougbu
dougbu commented Sep 20, 2021
View reviewed changes
Comment thread src/Middleware/ConcurrencyLimiter/sample/ConcurrencyLimiterSample.csproj Outdated
Comment thread src/Http/Routing/test/testassets/Benchmarks/Benchmarks.csproj
dougbu
dougbu commented Sep 20, 2021
View reviewed changes
Comment thread src/Http/Routing/test/testassets/Benchmarks/Benchmarks.csproj
dougbu
dougbu commented Sep 20, 2021
View reviewed changes
Comment thread src/Http/Routing/test/testassets/Benchmarks/Benchmarks.csproj
sebastienros
sebastienros reviewed Sep 20, 2021
View reviewed changes
Comment thread src/Http/Routing/test/testassets/Benchmarks/Benchmarks.csproj Outdated
@dougbu dougbu merged commit e639f4e into main Sep 22, 2021
@dougbu dougbu deleted the dougbu/less.frameworksss branch September 22, 2021 23:06
@ghost ghost added this to the 7.0-preview1 milestone Sep 22, 2021
@dougbu
Copy link
Copy Markdown
Contributor Author

dougbu commented Sep 22, 2021

/backport to release/6.0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 22, 2021

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1263812307

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 22, 2021

@dougbu an error occurred while backporting to release/6.0, please check the run log for details!

Error: @dougbu is not a repo collaborator, backporting is not allowed.

dougbu added a commit that referenced this pull request Sep 30, 2021
@dougbu
[release/6.0] <TargetFrameworks /> -> <TargetFramework />
0bc8b55 
- backport of #36727

`<TargetFrameworks />` -> `<TargetFramework />` (#36727)

  * `<TargetFrameworks />` -> `<TargetFramework />`
    - avoid useless transitions to inner builds
  * Remove most `$(BenchmarksTargetFramework)` use

  Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
@dougbu dougbu mentioned this pull request Sep 30, 2021
Merged
dougbu added a commit that referenced this pull request Sep 30, 2021
@dougbu
[release/6.0] <TargetFrameworks /> -> <TargetFramework /> (#37121)
f996456 
- backport of #36727

`<TargetFrameworks />` -> `<TargetFramework />` (#36727)

  * `<TargetFrameworks />` -> `<TargetFramework />`
    - avoid useless transitions to inner builds
  * Remove most `$(BenchmarksTargetFramework)` use

  Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
@jalbas2000 jalbas2000 mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastienros sebastienros sebastienros approved these changes

@Tratcher Tratcher Tratcher approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@javiercn javiercn Awaiting requested review from javiercn

@Pilchie Pilchie Awaiting requested review from Pilchie

@pranavkm pranavkm Awaiting requested review from pranavkm

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

5 participants

@dougbu @rainersigwald @sebastienros @Tratcher @wtgodbe