[release/6.0] Fix AppHost pack prebuilt usage in source-build#37760
Merged
Conversation
(cherry picked from commit 2984e3b)
Pilchie
added
the
area-infrastructure
Member
|
@dagood - this never got merged - does it need to for servicing? |
Member
Author
|
This PR's change is currently in 6.0.1xx as a patch file, so this PR would be required for patch removal: |
wtgodbe
approved these changes
Nov 10, 2021
wtgodbe
added
the
tell-mode
Member
|
Branches are open now, merging. |
ghost
added this to the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[release/6.0] Fix AppHost pack prebuilt usage in source-build
Cherry picked from commit 2984e3b, PR #37672.
This change removes the
NetCoreTargetingPackRootoverride during source-build to avoid unnecessarily downloading the apphost pack as a prebuilt dependency. I also updated the comment on the override to be more descriptive and added details on why/when it needs to be disabled for source-build.Added a non-source-build condition on
_InstallTargetingPackIntoLocalDotNetto prevent it from attempting to install the targeting pack into the source-build-wide SDK that's in use. This matches the same condition already present on_InstallFrameworkIntoLocalDotNet./cc @wtgodbe