Allow Hosting Bundle to be upgraded by MU#37966
Conversation
dbf1f42 to
bf306bf
Compare
|
Side curiosity question: Why did this PR conflict w/ release/6.0 etc.❔ |
|
Conflict is due to the format of this ProjectReference in main: vs 6.0/older: |
Backport #37338 if you like (the GitHub action didn't work for me last I checked |
| Result="exists" | ||
| Variable="OPT_NO_SHAREDFX_Should_Be_Set"/> | ||
|
|
||
| <util:RegistrySearch Id="opt_no_runtime_should_be_set" |
There was a problem hiding this comment.
I think you can simplify this further using a preprocessor variable to hold the condition (since it's the same) and then using a foreach to generate a parameterized search, e.g.
<?define Options=OPT_NO_X86;OPT_NO_RUNTIME?>
<?foreach Option in $(var.Options?>
<util:RegistrySearch Id="$(var.Option)_should_be_set">
</util:RegistrySearch>
<?endforeach?>
joeloff
left a comment
There was a problem hiding this comment.
Looks good, I left a final suggestion around code clean up to simplify maintenance in the future.
| Variable="$(var.Option)_Should_Be_Set"/> | ||
| <?endforeach?> | ||
|
|
||
| <util:RegistrySearch Condition="OPT_NO_ANCM_Should_Be_Set" |
There was a problem hiding this comment.
Delete the conditions since you're generating them through the preprocessor
I'm not sure where specifically we should document this. @rbhanda? |
Adds an .msi,
dotnet-hosting-options, which writes to the registry the value of the switches used when last installing the hosting bundle for a given Major.Minor version. Subsequent installs of that band of the hosting bundle will choose what the install in the following way:0for any switches not passed).0and write0to the registry for each switchNeed to backport this to all servicing branches. In December all customers who get this update thru MU will get a 1-time hit where, regardless of what they already had installed, the hosting bundle will install all components. We suspect most customers install everything anyways, and those who don't will be able to work around this by manually re-running the installer with whatever switches they passed the last time they installed the bundle manually. We should document that in our release notes (CC @rbhanda @danroth27).
6.0: #37967
5.0: #37968
3.1: #37969
Still working on 2.1