Use JSON Property Name attributes when creating ModelState Validation errors#39008
Merged
brunolins16 merged 17 commits intoJan 7, 2022
Merged
Conversation
ghost
added
the
area-mvc
brunolins16
changed the title
halter73
reviewed
Dec 14, 2021
pranavkm
reviewed
Dec 18, 2021
pranavkm
reviewed
Jan 3, 2022
…ationMetadataProvider.cs Co-authored-by: Pranav K <prkrishn@hotmail.com>
pranavkm
reviewed
Jan 3, 2022
Contributor
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
Could we get a few tests with these providers?
Member
Author
I am working on it, just pushed the unit tests for STJProvider. |
pranavkm
approved these changes
Jan 7, 2022
Contributor
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
This looks great. Do you mind filing a doc issue so we can tell users how to use / configure these? Thanks!
Comment on lines
+73
to
+76
| { | ||
| new UpperCaseJsonNamingPolicy(), | ||
| new CamelCaseNamingStrategy() | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| { | |
| new UpperCaseJsonNamingPolicy(), | |
| new CamelCaseNamingStrategy() | |
| }; | |
| { | |
| new UpperCaseJsonNamingPolicy(), | |
| new CamelCaseNamingStrategy() | |
| }; |
Nit, feel free to ignore it / do it in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39010