Skip to content

[release/6.0] Don't reference test asset projects in Build.props#39733

Merged
wtgodbe merged 5 commits intodotnet:release/6.0from
wtgodbe:wtgodbe/CantAccessFile6
Feb 2, 2022
Merged

[release/6.0] Don't reference test asset projects in Build.props#39733
wtgodbe merged 5 commits intodotnet:release/6.0from
wtgodbe:wtgodbe/CantAccessFile6

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Jan 24, 2022

Backport of #39336 to improve build reliability

@wtgodbe wtgodbe requested a review from a team January 24, 2022 18:48
@ghost ghost added this to the 6.0.x milestone Jan 24, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jan 24, 2022

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 24, 2022
@dougbu
Copy link
Copy Markdown
Contributor

dougbu commented Jan 24, 2022

Should this be in area-infrastructure

@wtgodbe wtgodbe added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 24, 2022
@dougbu
Copy link
Copy Markdown
Contributor

dougbu commented Jan 24, 2022

Bet this will fail due to problems @HaoK and @BrennanConroy were working on in #39687 and #39679. Should we create a feature branch combining those two so that CI validations can be done before we start merging to 'release/6.0'❔ That would enable me to validate #39683 too 😄

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jan 24, 2022

#39679 now combines both of those PRs

@wtgodbe wtgodbe merged commit 4ea6623 into dotnet:release/6.0 Feb 2, 2022
@wtgodbe wtgodbe deleted the wtgodbe/CantAccessFile6 branch February 2, 2022 17:35
@wtgodbe wtgodbe modified the milestones: 6.0.x, 6.0.3 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants