Skip to content

return value for single HttpContext parameter#40235

Merged
halter73 merged 8 commits into
dotnet:mainfrom
feiyun0112:fix-39956
Mar 3, 2022
Merged

return value for single HttpContext parameter#40235
halter73 merged 8 commits into
dotnet:mainfrom
feiyun0112:fix-39956

Conversation

@feiyun0112
Copy link
Copy Markdown
Contributor

@feiyun0112 feiyun0112 commented Feb 15, 2022

fix #39956

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Feb 15, 2022
davidfowl
davidfowl reviewed Feb 15, 2022
View reviewed changes
Comment thread src/Http/Routing/src/Builder/EndpointRouteBuilderExtensions.cs Outdated
@feiyun0112 feiyun0112 requested a review from davidfowl February 16, 2022 04:08
davidfowl
davidfowl reviewed Feb 16, 2022
View reviewed changes
Comment thread src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs Outdated
@feiyun0112 feiyun0112 requested a review from davidfowl February 17, 2022 00:53
@davidfowl
Copy link
Copy Markdown
Member

davidfowl commented Feb 21, 2022

We do need a test but you can add a test here https://github.com/dotnet/aspnetcore/blob/ad46e0355613b8cfca9d401a44d9eba7004a175b/src/Http/Routing/test/UnitTests/Builder/EndpointRoutingApplicationBuilderExtensionsTest.cs

OR here

https://github.com/dotnet/aspnetcore/blob/ad46e0355613b8cfca9d401a44d9eba7004a175b/src/Http/Routing/test/UnitTests/Builder/RequestDelegateEndpointRouteBuilderExtensionsTest.cs

@halter73 halter73 enabled auto-merge (squash) March 2, 2022 21:26
@davidfowl
Copy link
Copy Markdown
Member

davidfowl commented Mar 3, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 3, 2022

Azure Pipelines successfully started running 3 pipeline(s).

@halter73 halter73 merged commit c962827 into dotnet:main Mar 3, 2022
@ghost ghost added this to the 7.0-preview3 milestone Mar 3, 2022
@davidfowl
Copy link
Copy Markdown
Member

davidfowl commented Mar 3, 2022

Great work @feiyun0112 !

@feiyun0112 feiyun0112 deleted the fix-39956 branch March 3, 2022 05:42
@halter73 halter73 mentioned this pull request Nov 9, 2022
Open
1 task
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
@andrew-vdb andrew-vdb mentioned this pull request Jul 31, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

@davidfowl davidfowl davidfowl approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@davidfowl davidfowl

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0-preview3

Development

Successfully merging this pull request may close these issues.

Minimal APIs: Moving handler with single parameter of type HttpContext to separate method results in empty response

5 participants

@feiyun0112 @davidfowl @halter73 @adityamandaleeka @amcasey