Add support for route handler filter factories#40667
Merged
Merged
Conversation
ghost
added
the
davidfowl
reviewed
Mar 11, 2022
davidfowl
reviewed
Mar 11, 2022
davidfowl
reviewed
Mar 11, 2022
captainsafia
force-pushed
the
ef-factory
branch
from
1c31afa to
0c8e8d7
Compare
captainsafia
added
old-area-web-frameworks-do-not-use
davidfowl
reviewed
Mar 11, 2022
captainsafia
force-pushed
the
ef-factory
branch
from
0c8e8d7 to
39b8721
Compare
davidfowl
reviewed
Mar 12, 2022
davidfowl
reviewed
Mar 12, 2022
davidfowl
reviewed
Mar 12, 2022
Co-authored-by: David Fowler <davidfowl@gmail.com>
captainsafia
requested review from
Tratcher,
halter73 and
javiercn
as code owners
davidfowl
reviewed
Mar 14, 2022
Member
BrennanConroy
left a comment
BrennanConroy
left a comment
There was a problem hiding this comment.
Can a test be added that asserts some endpoint metadata?
halter73
reviewed
Mar 14, 2022
| /// <returns>An awaitable result of calling the handler and apply | ||
| /// any modifications made by filters in the pipeline.</returns> | ||
| ValueTask<object?> InvokeAsync(RouteHandlerFilterContext context, Func<RouteHandlerFilterContext, ValueTask<object?>> next); | ||
| ValueTask<object?> InvokeAsync(RouteHandlerInvocationContext context, RouteHandlerFilterDelegate next); |
Member
There was a problem hiding this comment.
How do we feel about adding a RouteHandlerContext parameter? We can try to approve this over email if we like it.
Suggested change
| ValueTask<object?> InvokeAsync(RouteHandlerInvocationContext context, RouteHandlerFilterDelegate next); | |
| ValueTask<object?> InvokeAsync(RouteHandlerContext routeContext, RouteHandlerInvocationContext invocationContext, RouteHandlerFilterDelegate next); |
Member
There was a problem hiding this comment.
Why? This should e a constructor argument, like middleware has the magic next no?
Contributor
Author
There was a problem hiding this comment.
How does middleware pass the magic next?
The implementation I just pushed passes the RouteHandlerContext as an argument to the object factory generated when the user utilizes the AddFilter<TFilterType>() overload.
halter73
reviewed
Mar 14, 2022
halter73
reviewed
Mar 14, 2022
halter73
reviewed
Mar 14, 2022
davidfowl
reviewed
Mar 15, 2022
| /// provided to a route handler. | ||
| /// </summary> | ||
| public class RouteHandlerInvocationContext | ||
| public sealed class RouteHandlerInvocationContext |
Member
There was a problem hiding this comment.
Don't seal this one. We'll end up un sealing it.
Contributor
Author
There was a problem hiding this comment.
We discussed this during API review. Unsealing doesn't have a cost, but sealing does so we are taking the more flexible option to start.
If we ship the parameters change in preview4, it shouldn't be too bad.
halter73
approved these changes
Mar 15, 2022
halter73
reviewed
Mar 15, 2022
halter73
reviewed
Mar 15, 2022
halter73
reviewed
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40513