Avoiding ParameterBindingMethodCache exceptions in MVC#40738
Merged
Conversation
pranavkm
approved these changes
Mar 17, 2022
|
|
||
| IsConvertibleType = TypeDescriptor.GetConverter(ModelType).CanConvertFrom(typeof(string)); | ||
| IsParseableType = ModelMetadata.FindTryParseMethod(ModelType) is not null; | ||
| IsParseableType = FindTryParseMethod(ModelType) is not null; |
Contributor
There was a problem hiding this comment.
You could consider moving line 651 above this and use UnderlyingOrModelType instead.
halter73
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MVC, we don't need to throw an
InvalidOperationExceptionwhen an invalidTryParseis detected, since it will fallback to aConverterif one exists or to the previous behavior treating the type as a complex type. Also, the exception is already swallowed.This PR includes a small change to the
Microsoft.AspNetCore.Http.ParameterBindingMethodCacheto avoid throwing and handling the exception in MVC.The change consists of adding a new optional parameter to the constructor:
And the usage of this new information to avoid the exception to be thrown, eg:
if (candidateInterfaceMethodInfo is not null) { - throw new InvalidOperationException($"{TypeNameHelper.GetTypeDisplayName(type, fullName: false)} implements multiple interfaces defining a static {interfaceMethod} method causing ambiguity."); + return !throwOnInvalidMethod ? null : + throw new InvalidOperationException($"{TypeNameHelper.GetTypeDisplayName(type, fullName: false)} implements multiple interfaces defining a static {interfaceMethod} method causing ambiguity."); }Related PR: #40233