Consider registering the authentication state provider conditionally#41247
Merged
Conversation
ghost
added
area-blazor
Contributor
|
Thanks for your PR, @damienbod. |
Member
|
@mkArtakMSFT yep, but I want to have a quick discussion with some other folks before we commit to this change. That's why the original issue is in the planning milestone and doesn't have good-first-issue, up-for-grabs labels yet. |
Member
|
@japui I'm not sure why you're posting these comments on many issues, but each time you do, it sends update notifications to potentially large numbers of people. Would you mind not posting these comments? |
javiercn
approved these changes
Jul 26, 2022
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Looks great,
Thanks for the contribution @damienbod!
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider registering the authentication state provider conditionally
fixes #41235