Skip to content

[user-jwts] Read and generate secrets ID with SecretsManager#42006

Merged
captainsafia merged 4 commits into
dotnet:mainfrom
captainsafia:jwts-secrets
Jun 9, 2022
Merged

[user-jwts] Read and generate secrets ID with SecretsManager#42006
captainsafia merged 4 commits into
dotnet:mainfrom
captainsafia:jwts-secrets

Conversation

@captainsafia
Copy link
Copy Markdown
Contributor

Closes #41975 and part of #41888.

  • Change up build configuration to support referencing dotnet-user-secrets
  • Use SecretManager build target to extract user secrets ID
  • Create secret ID if it has not been defined

@captainsafia captainsafia requested review from a team, Pilchie, dougbu and wtgodbe as code owners June 3, 2022 01:05
@captainsafia captainsafia added area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels feature-userjwts The `dotnet user-jwts` CLI tool labels Jun 3, 2022
Comment thread src/Tools/dotnet-user-secrets/src/Internal/ProjectIdResolver.cs Outdated
Comment thread src/Tools/dotnet-user-jwts/src/dotnet-user-jwts.csproj Outdated
Comment thread src/Tools/Shared/SecretsHelpers/UserSecretsCreator.cs Outdated
@captainsafia captainsafia enabled auto-merge (squash) June 9, 2022 15:55
@captainsafia captainsafia merged commit 9ad5dc9 into dotnet:main Jun 9, 2022
@ghost ghost added this to the 7.0-preview6 milestone Jun 9, 2022
captainsafia pushed a commit to captainsafia/aspnetcore that referenced this pull request Jun 13, 2022
…42006)

* [user-jwts] Read secrets ID from SecretsManager and generate missing secrets
* Address feedback from review
* Add shared localizations strings for secrets
* Update localization and address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-userjwts The `dotnet user-jwts` CLI tool old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

user-jwts should just create the UserSecretsId if not found

5 participants