Diff TestGroupName for project templates tests#42214
Merged
DamianEdwards merged 3 commits intoJun 16, 2022
Merged
Conversation
ghost
added
the
area-mvc
BrennanConroy
requested changes
Jun 15, 2022
Member
BrennanConroy
left a comment
BrennanConroy
left a comment
There was a problem hiding this comment.
Likely need to update https://github.com/dotnet/aspnetcore/blob/main/eng/Build.props#L197
Contributor
|
Correct @BrennanConroy. Sorry @DamianEdwards that this wasn't the right fix. This is helpful but changing that one line might be enough. (https://dev.azure.com/dnceng/public/_build/results?buildId=1827055&view=logs&j=3f6d4e0f-1b71-56b5-361e-d95b6e6da15a&t=e4ee6667-9b0a-5a6e-4e24-bcba939f2af2 doesn't mention the word "templates" at all. Confirmed same checking a couple of the Helix work item lists.) |
BrennanConroy
approved these changes
Jun 15, 2022
TanayParikh
approved these changes
Jun 16, 2022
DamianEdwards
deleted the
damianedwards/project-template-tests-group-name-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix project templates tests not showing up in CI build results.