Skip to content

[Blazor] Dynamic authentication requests#42692

Merged
javiercn merged 22 commits intomainfrom
javiercn/dynamic-authentication-requests
Aug 12, 2022
Merged

[Blazor] Dynamic authentication requests#42692
javiercn merged 22 commits intomainfrom
javiercn/dynamic-authentication-requests

Conversation

@javiercn
Copy link
Copy Markdown
Member

@javiercn javiercn commented Jul 12, 2022

Fixes #42580

Adds a new type InteractiveRequestOptions that contains the data developers can use to customize the authentication flows. The data is passed in through the State parameter to the remoteauthenticatorviewcore which then handles the authentication process.

  • Updates RemoteAuthenticatorViewCore to rely on navigation history state to pass in data around for authentication operations.
  • Adds logging to the RemoteAuthenticatorViewCore
  • Updates AuthenticationService.ts to handle requesting additional tokens
  • Updates AuthenticationService.ts to account for the interactiverequest options.
  • Adds E2E tests that demonstrate:
    • Sign in can be customized.
    • Requesting a token interactively for a second resource.

<StaticWebAssetProjectConfiguration Include="@(_IdentityUI)" />
</ItemGroup>
</Target>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just fixes how we consume identity UI as a class library, which was broken.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a comment indicating what all this stuff is for. i.e., in what way it would be broken otherwise, and why it has to be fixed here rather than in whatever added the identity UI files to the project in the first place.

Hopefully you can appreciate that basically nobody in the world would have any idea why we're doing this apart from you :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a comment for this.

@javiercn javiercn marked this pull request as ready for review July 13, 2022 14:17
@javiercn javiercn requested review from a team and Pilchie as code owners July 13, 2022 14:17
@javiercn javiercn removed the request for review from Pilchie July 13, 2022 14:18
@javiercn javiercn changed the title Javiercn/dynamic authentication requests [Blazor] Dynamic authentication requests Jul 13, 2022
@TanayParikh TanayParikh added area-blazor Includes: Blazor, Razor Components feature-authentication labels Jul 13, 2022
@javiercn javiercn force-pushed the javiercn/dynamic-authentication-requests branch from 5ff0b4c to 1c22136 Compare August 9, 2022 18:45
@javiercn javiercn merged commit e825775 into main Aug 12, 2022
@javiercn javiercn deleted the javiercn/dynamic-authentication-requests branch August 12, 2022 09:35
@ghost ghost added this to the 7.0-rc1 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components feature-blazor-wasm-auth

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Blazor][Wasm] Dynamic and extensible authentication requests

3 participants