Rename ConfigureRouteHandlerJsonOptions to ConfigureHttpJsonOptions#42747
Merged
Conversation
captainsafia
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
ghost
added
the
captainsafia
added
old-area-web-frameworks-do-not-use
captainsafia
force-pushed
the
cs/rename-options-config
branch
from
daf0e12 to
0d94ead
Compare
Member
BrennanConroy
left a comment
BrennanConroy
left a comment
There was a problem hiding this comment.
/// The options configured here will only affect JSON returned and processed
/// from route handlers
/// Configures options used for reading and writing JSON by route handlers.
Do these doc comments need to be updated? The main point of this change is it's not specific to route handlers.
Contributor
Author
|
Sure! How does this sound? /// <summary>
/// Configures options used for reading and writing JSON when using
/// <see cref="O:Microsoft.AspNetCore.Http.HttpRequestJsonExtensions.ReadFromJsonAsync" />
/// and <see cref="O:Microsoft.AspNetCore.Http.HttpResponseJsonExtensions.WriteAsJsonAsync" />.
/// </summary> |
BrennanConroy
approved these changes
Jul 19, 2022
This was referenced Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42718.