Forward port "Improve Default Blazor WebAssembly Loading Experience"#42813
Merged
cerasamson merged 1 commit intoJul 19, 2022
Merged
Conversation
* Added loader SVG and CSS styling * Add WebAssemblyProgressService, WebAssemblyProgressReporter * Add styling for setProgress, fix resourcesTotal * Implement singleton pattern, fix CSS styling * Convert % text to SVG * Add WebAssemblyProgressService as IBlazor global export * Modify CSS classes, added TSDoc to public methods * Modify CSS element names * Update src/Components/Web.JS/src/Boot.WebAssembly.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Update src/Components/Web.JS/src/Platform/WebAssemblyProgressReporter.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Check for additional resources; percentage styling * Update app.css * Create global SetProgress, pass in ProgressService * Vertically center loading circle * Update Boot.WebAssembly.ts * Update src/Components/Web.JS/src/Platform/WebAssemblyResourceLoader.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Fix possible undefined wasmLoadingSetProgress * Remove setProgressFunction from GlobalExports * Update blazor.server.js * Update src/Components/Web.JS/src/Platform/WebAssemblyProgressReporter.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Update src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Update src/Components/Web.JS/src/Platform/WebAssemblyStartOptions.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Remove progress ring transition duration * Update src/Components/Web.JS/src/Platform/WebAssemblyStartOptions.ts * (WIP) Bring all .ts changes to MonoPlatform.ts * Remove reporter/service classes, update loading styling * Center percentage text * Update app.css * Add additional checks for element types * Prevent exception by changing to div id = "app" * Update src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * WIP remove CSS id * Concat promises for setProgress function * Update src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Update src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * CSS updates * Update src/ProjectTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/Client/wwwroot/css/app.css * Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> * Update src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts * Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> * Update src/ProjectTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/Client/wwwroot/css/app.css * Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> * Add default "Loading" test * Update Templates.Blazor.WebAssembly.Tests.csproj * Update Templates.Blazor.WebAssembly.Tests.csproj Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com> Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
TanayParikh
approved these changes
Jul 19, 2022
Contributor
TanayParikh
left a comment
TanayParikh
left a comment
There was a problem hiding this comment.
Approving forward port to main
ghost
added this to the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of Improve Default Blazor WebAssembly Loading Experience.