Skip to content

Remove call to .Any() from ProblemDetailsDefaultWriter #43055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brunolins16 merged 2 commits into from
Aug 3, 2022
Merged

Remove call to .Any() from ProblemDetailsDefaultWriter #43055

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
638d793
Remove call to .Any()
brunolins16 Aug 2, 2022
52e2811
Removing System.Linq
brunolins16 Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;
using System.Linq;
using System.Text.Json.Serialization;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Options;
Expand All @@ -26,9 +25,18 @@ public bool CanWrite(ProblemDetailsContext context)
var httpContext = context.HttpContext;
var acceptHeader = httpContext.Request.Headers.Accept.GetList<MediaTypeHeaderValue>();

if (acceptHeader?.Any(h => _jsonMediaType.IsSubsetOf(h) || _problemDetailsJsonMediaType.IsSubsetOf(h)) == true)
if (acceptHeader is { Count: > 0 })
{
return true;
for (var i = 0; i < acceptHeader.Count; i++)
{
var acceptHeaderValue = acceptHeader[i];

if (_jsonMediaType.IsSubsetOf(acceptHeaderValue) ||
_problemDetailsJsonMediaType.IsSubsetOf(acceptHeaderValue))
{
return true;
}
}
}

return false;
Expand Down