Expose entire EndpointBuilder to filter factories#43255
Closed
halter73 wants to merge 4 commits into
Closed
Conversation
halter73
requested review from
a team,
BrennanConroy,
Tratcher and
javiercn
as code owners
halter73
commented
Aug 13, 2022
Co-authored-by: Brennan <brecon@microsoft.com>
Pilchie
added
the
old-area-web-frameworks-do-not-use
Member
Author
|
Closing in favor of #43543. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flows the entire
EndpointBuilderthrough to endpoint filter factories. This gives more context like the display name to filters, and reduces the number of properties inRequestDelegateFactoryOptionsandEndpointFilterFactoryContext. And since theEndpointBuilderis usually aRouteEndpointBuilder, filters can observe the route pattern as well.EndpointBuilder.RequestDelegatemust benullif it is passed into theRequestDelegateFactory.Create(). TheRequestDelegateFactorysets theRequestDelegateto the same instance returned viaRequestDelegateResult.RequestDelegate. This is similar to how we were already mutating the passed-in metadata that was also then returned.Fixes #43000