Update dotnet-getdocument to support minimal APIs#43701
Merged
Conversation
captainsafia
added
the
old-area-web-frameworks-do-not-use
ghost
added
the
area-commandlinetools
dougbu
approved these changes
Sep 1, 2022
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Approving w/ the assumption that you address the comments below. I don't need to check again 😀
Contributor
Author
|
@Pilchie Can I get RC2 approval for this? |
Member
|
Approved for .NET 7 RC2. |
Contributor
Author
|
@dotnet/aspnet-admins Can I get help merging this? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR update the
dotnet getdocumenttool to react to changes in hosting that were shipped in .NET 6.The hosting changes were incongruent with the strategy that the
getdocumenttool used to extract the active ServiceProvider from the application assembly.Fixes #43391
Customer Impact
Without this change, OpenAPI document generation in the CLI and client generation in Visual Studio would fail to produce the necessary schemas and code for minimal API endpoints in user applications.
Regression?
Risk
Low because:
getdocumenttoolVerification
Packaging changes reviewed?