Playwright 🎭 🛠️ #45682
Conversation
| cancelTimeoutInMinutes: 30 | ||
| buildArgs: -all -pack -test -binaryLog /p:SkipHelixReadyTests=true /p:SkipIISNewHandlerTests=true /p:SkipIISTests=true | ||
| /p:SkipIISExpressTests=true /p:SkipIISNewShimTests=true /p:RunTemplateTests=false | ||
| /p:SkipIISExpressTests=true /p:SkipIISNewShimTests=true /p:RunTemplateTests=false /p:RunBlazorPlaywrightTemplateTests=true |
There was a problem hiding this comment.
Will setting this new variable (RunBlazorPlaywrightTemplateTests) to false result in the current behavior (as if we don't have this change in place)?
There was a problem hiding this comment.
It's fine to just omit RunBlazorPlaywrightTemplateTests in that case as it'll default to using the value of RunTemplateTests, but yes setting it to false would work as well.
| } | ||
|
|
||
| [Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")] | ||
| [Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/45736")] |
There was a problem hiding this comment.
The issue here was blocked on a Playwright issue, which they have resolved with the following comment:
Does that impact our decisions regarding this in any way?
I assume you're trying to wrap up your work already, and leaving this to be handled as part of the work on the linked issue is the right thing to do. So mostly wanted to note the progress on the dependency.
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
ghost
added
the
pending-ci-rerun
|
The problem is that the |
wtgodbe
removed
the
pending-ci-rerun
|
/azp run |
|
Commenter does not have sufficient privileges for PR 45682 in repo dotnet/aspnetcore |
5 participants
Enable Playwright Tests
Fixes: #30761
Fixes: #30882