Skip to content

Support SkipStatusCodePages when not using WebApplication builder and UseStatusCodePagesWithReExecute#46109

Merged
Tratcher merged 2 commits into
dotnet:mainfrom
frederikrosenberg:status-code-middleware-skip
Jan 18, 2023
Merged

Support SkipStatusCodePages when not using WebApplication builder and UseStatusCodePagesWithReExecute#46109
Tratcher merged 2 commits into
dotnet:mainfrom
frederikrosenberg:status-code-middleware-skip

Conversation

@frederikrosenberg
Copy link
Copy Markdown
Contributor

Add support for SkipStatusCodePages attribute when using minimal APIs with a non WebApplication builder and UseRouting.

I have implemented the suggested fix as stated in the issue.

Fixes #39472

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Jan 15, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jan 15, 2023

Thanks for your PR, @frederikrosenberg. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Comment thread src/Middleware/Diagnostics/src/StatusCodePage/StatusCodePagesMiddleware.cs Outdated
@Tratcher Tratcher enabled auto-merge (squash) January 18, 2023 18:16
@Tratcher Tratcher self-assigned this Jan 18, 2023
@Tratcher
Copy link
Copy Markdown
Member

Thanks

@Tratcher Tratcher merged commit 1f62c43 into dotnet:main Jan 18, 2023
@ghost ghost added this to the 8.0-preview1 milestone Jan 18, 2023
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UseStatusCodePagesWithReExecute should respect [SkipStatusCodePages]

3 participants