Skip Source Build for now#46190
Merged
Merged
Conversation
dougbu
approved these changes
Jan 20, 2023
Contributor
dougbu
left a comment
There was a problem hiding this comment.
nit: It doesn't matter that much, but we don't usually check in commented-out or unreachable code. Could have just deleted the job and reverted the commit when the bug is fixed.
sebastienros
approved these changes
Jan 20, 2023
wtgodbe
added a commit
that referenced
this pull request
Jan 24, 2023
* Update dependencies from https://github.com/dotnet/arcade build 20230123.10 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 8.0.0-beta.23067.5 -> To Version 8.0.0-beta.23073.10 * Revert "Don't depend on source-build job while it isn't running (#46220)" This reverts commit 7369057. * Revert "Skip Source Build for now (#46190)" This reverts commit c77deeb. Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: wtgodbe <wigodbe@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source Build failures are blocking CI & Official builds until dotnet/source-build#3111 is resolved - let's skip that job until it's fixed
Related - #46191