Skip to content

Skip Source Build for now#46190

Merged
wtgodbe merged 1 commit into
mainfrom
wtgodbe/SkipSB
Jan 20, 2023
Merged

Skip Source Build for now#46190
wtgodbe merged 1 commit into
mainfrom
wtgodbe/SkipSB

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Jan 20, 2023

Source Build failures are blocking CI & Official builds until dotnet/source-build#3111 is resolved - let's skip that job until it's fixed

Related - #46191

@wtgodbe wtgodbe requested review from a team and dougbu as code owners January 20, 2023 18:17
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 20, 2023
Copy link
Copy Markdown
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It doesn't matter that much, but we don't usually check in commented-out or unreachable code. Could have just deleted the job and reverted the commit when the bug is fixed.

@wtgodbe wtgodbe enabled auto-merge (squash) January 20, 2023 18:22
@wtgodbe wtgodbe merged commit c77deeb into main Jan 20, 2023
@wtgodbe wtgodbe deleted the wtgodbe/SkipSB branch January 20, 2023 20:08
@ghost ghost added this to the 8.0-preview1 milestone Jan 20, 2023
wtgodbe added a commit that referenced this pull request Jan 24, 2023
wtgodbe added a commit that referenced this pull request Jan 24, 2023
* Update dependencies from https://github.com/dotnet/arcade build 20230123.10

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23067.5 -> To Version 8.0.0-beta.23073.10

* Revert "Don't depend on source-build job while it isn't running (#46220)"

This reverts commit 7369057.

* Revert "Skip Source Build for now (#46190)"

This reverts commit c77deeb.

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: wtgodbe <wigodbe@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants