[release/7.0] Prefer TypeConverter over TryParse

[github-actions]

Backport of #46577 to release/7.0

/cc @brunolins16

Prefer TypeConverter over TryParse

This PR reverts a break change introduced in .NET 7 where the MVC Model Binding prefers a TryParse method over a TypeConverter for a simple type.

Fixes #46384
Fixes #45338

Customer Impact

In .NET 7 was added a new Model Binder to enable binding from a string using a known TryParse method, in addition to a TypeConverter, however, was decided to register the new Model Binder to be executed first (preferring TryParse over TypeConverter) while all the functionality still in place and users still able to use a TypeConverter there are situations where a type already have a TryParse method and a TypeConverter and they have different default options (#45338), or when a user is trying to create a custom TypeConverter to these types (#46384).

This PR keeps the new Model Binder, however, will maintain compatibly with .NET 6 by preferring TypeConverter over a TryParse method.

Regression?

• Yes
• No

The regression was introduced in .NET when the new TryParseModelBinder was added.

Risk

• High
• Medium
• Low

All the new functionality added in .NET 7 (Bind withTryParse) will keep working, however, we are making it more compatible with what we have before.

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

[ghost]

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[Nick-Stanton]

I was curious about this when we were looking at individual DateOnly and TimeOnly model binders. I'll leave the official approving review to someone more knowledgeable, but this fix looks great to me

[brunolins16]

someone more knowledgeable, but this fix looks great to me

Yeah, when we added the TryParseModelBinder was decided to prefer it over the TypeConverter but we got few feedbacks already that it was a bad decision since our recommendation is create a TypeConverter when bind from string.

https://learn.microsoft.com/en-us/aspnet/core/mvc/advanced/custom-model-binding?view=aspnetcore-6.0#recommendations-and-best-practices

[ghost]

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

[ghost]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

[captainsafia]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[ghost]

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

[captainsafia]

Approved via email.

@dotnet/aspnet-build Can I get help merging?