Sections support#46727
Merged
surayya-MS merged 34 commits intodotnet:mainfrom Mar 8, 2023
Merged
Conversation
ghost
added
the
5 tasks
Member
MackinnonBuck
left a comment
MackinnonBuck
left a comment
There was a problem hiding this comment.
This is looking great! I just added a few more comments with some minor thoughts.
Before approving, I would still like to see what others think about this suggestion.
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
MackinnonBuck
approved these changes
Feb 28, 2023
Member
MackinnonBuck
left a comment
MackinnonBuck
left a comment
There was a problem hiding this comment.
This is looking great 🎉 Thank you for your perseverance on this!
I have a few remaining nits but nothing that should block the approval of this PR. I think this is ready to go after all tests pass (and the API gets approved).
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
…tcore into sectionsSupport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sections support
API Proposal: #46937
Description
SectionContentandSectionOutletpublicSectionContent.IsDefaultContentNameand used objectSectionIdas a section identifierFixes #28182