Skip to content

[release/7.0] Backport pr 48892 to 7.0#48911

Merged
danmoseley merged 2 commits intodotnet:release/7.0from
mitchdenny:backport-pr-48892-to-7.0
Jul 7, 2023
Merged

[release/7.0] Backport pr 48892 to 7.0#48911
danmoseley merged 2 commits intodotnet:release/7.0from
mitchdenny:backport-pr-48892-to-7.0

Conversation

@mitchdenny
Copy link
Copy Markdown
Member

@mitchdenny mitchdenny commented Jun 20, 2023

Backport of #48892

@ghost ghost added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Jun 20, 2023
@mitchdenny mitchdenny changed the title Backport pr 48892 to 7.0 [release/7.0] Backport pr 48892 to 7.0 Jun 20, 2023
@mitchdenny mitchdenny changed the base branch from main to release/7.0 June 20, 2023 06:16
@mitchdenny mitchdenny requested review from Tratcher and mgravell June 20, 2023 06:17
@mitchdenny mitchdenny self-assigned this Jun 20, 2023
@mitchdenny mitchdenny added the Servicing-consider Shiproom approval is required for the issue label Jun 20, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jun 20, 2023

Hi @mitchdenny. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@mkArtakMSFT mkArtakMSFT added area-runtime and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Jun 20, 2023
@amcasey
Copy link
Copy Markdown
Member

amcasey commented Jun 20, 2023

The code looks right, but what made this interesting enough to backport?

@davidfowl
Copy link
Copy Markdown
Member

davidfowl commented Jun 20, 2023

Custom request to backport

@danmoseley danmoseley added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jun 22, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jun 22, 2023

Hi @mitchdenny. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@danmoseley
Copy link
Copy Markdown
Member

danmoseley commented Jun 22, 2023

approved by tactics

@mitchdenny
Copy link
Copy Markdown
Member Author

mitchdenny commented Jun 22, 2023

There is a fix we need for this PR. The unit test itself has a bug. I'll update it this morning.

@mitchdenny
Copy link
Copy Markdown
Member Author

mitchdenny commented Jun 22, 2023

Latest commit was to fix up a test case that was flakey (we picked up on main so have applied it to the backport as well so we don't make the servicing branch flakey.

@ghost
Copy link
Copy Markdown

ghost commented Jun 30, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 30, 2023
@mitchdenny
Copy link
Copy Markdown
Member Author

mitchdenny commented Jun 30, 2023

/azp run

@ghost ghost removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 30, 2023
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 30, 2023

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Jul 6, 2023

@mitchdenny I can merge this once it is review-approved

@mitchdenny
Copy link
Copy Markdown
Member Author

mitchdenny commented Jul 7, 2023

Forwarded you an e-mail where approval was given.

@danmoseley
Copy link
Copy Markdown
Member

danmoseley commented Jul 7, 2023

@mitchdenny I believe he means, someone signed off on the review

danmoseley
danmoseley approved these changes Jul 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears to be accurate port

@danmoseley danmoseley merged commit e3e2ef1 into dotnet:release/7.0 Jul 7, 2023
@ghost ghost added this to the 7.0.10 milestone Jul 7, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmoseley danmoseley danmoseley approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@mgravell mgravell Awaiting requested review from mgravell

Assignees

@mitchdenny mitchdenny

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue

Projects

None yet

Milestone

7.0.10

Development

Successfully merging this pull request may close these issues.

6 participants

@mitchdenny @amcasey @davidfowl @danmoseley @wtgodbe @mkArtakMSFT