Skip to content

[Blazor] Public API for interacting with runtime#49420

Merged
maraf merged 9 commits intodotnet:mainfrom
maraf:BlazorRuntimeApi
Jul 19, 2023
Merged

[Blazor] Public API for interacting with runtime#49420
maraf merged 9 commits intodotnet:mainfrom
maraf:BlazorRuntimeApi

Conversation

@maraf
Copy link
Copy Markdown
Member

@maraf maraf commented Jul 14, 2023 •
edited
Loading

Closes #49264

@maraf maraf added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Jul 14, 2023
@maraf maraf added this to the 8.0-preview7 milestone Jul 14, 2023
@maraf maraf self-assigned this Jul 14, 2023
@maraf maraf marked this pull request as ready for review July 14, 2023 21:45
@maraf maraf requested a review from a team as a code owner July 14, 2023 21:45
@maraf
Merge remote-tracking branch 'upstream/main' into BlazorRuntimeApi
25178f9 
# Conflicts:
#	src/Components/Web.JS/dist/Release/blazor.server.js
#	src/Components/Web.JS/dist/Release/blazor.web.js
#	src/Components/Web.JS/dist/Release/blazor.webview.js
@maraf maraf changed the title [Blazor] API for interacting with runtime [Blazor] Public API for interacting with runtime Jul 18, 2023
SteveSandersonMS
SteveSandersonMS reviewed Jul 18, 2023
View reviewed changes
Comment thread src/Components/WebAssembly/testassets/StandaloneApp/Pages/ConfigureRuntime.razor Outdated
@SteveSandersonMS SteveSandersonMS self-requested a review July 18, 2023 17:27
SteveSandersonMS
SteveSandersonMS approved these changes Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now so it has a chance of being merged before the codecomplete cutoff today, assuming you're able to make the E2E test update mentioned in the comments.

But no pressure to complete this today if that's inconvenient for you, of course!

@maraf maraf merged commit 5b2facb into dotnet:main Jul 19, 2023
@maraf maraf deleted the BlazorRuntimeApi branch July 19, 2023 11:29
@ghost ghost modified the milestones: 8.0-preview7, 8.0-rc1 Jul 19, 2023
@guardrex guardrex mentioned this pull request Aug 22, 2023
Closed
@guardrex guardrex mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees

@maraf maraf

Labels

area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly

Projects

None yet

Milestone

8.0-rc1

Development

Successfully merging this pull request may close these issues.

[Blazor] Have a way to configure dotnet runtime for blazor apps

2 participants

@maraf @SteveSandersonMS