Fix radio button reset after submitting enhanced form#51796
Fix radio button reset after submitting enhanced form#51796surayya-MS merged 5 commits intodotnet:mainfrom
Conversation
SteveSandersonMS
left a comment
There was a problem hiding this comment.
The updated fix looks great!
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
|
Hi @surayya-MS. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
/backport to release/8.0 |
|
Hi @surayya-MS. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/6768405553 |
|
@surayya-MS an error occurred while backporting to release/8.0, please check the run log for details! Error: @surayya-MS is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=surayya-MS |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/6774120326 |
|
@mkArtakMSFT an error occurred while backporting to release/8.0, please check the run log for details! Error: @mkArtakMSFT is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=mkArtakMSFT |
|
@surayya-MS the reason for this error is described here: #36832 (comment) |
|
/backport to release/8.0 |
|
Hi @surayya-MS. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/6799587547 |
|
@surayya-MS backporting to release/8.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: fix radio button reset when submitting enhanced form
Applying: rename test
Applying: new fix
error: sha1 information is lacking or useless (src/Components/Web.JS/src/Services/NavigationEnhancement.ts).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 new fix
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@surayya-MS an error occurred while backporting to release/8.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
|
@mkArtakMSFT @surayya-MS maybe cherry-pick?:) |
|
Hi @AlexKovynev. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
* fix radio button reset when submitting enhanced form * rename test * new fix * Update src/Components/Web.JS/test/DomSync.test.ts Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> * Update src/Components/Web.JS/src/Rendering/DomMerging/DomSync.ts Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> --------- Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
|
@AlexKovynev FYI, the release/8.0 branch has been closed for GA for a while now. These fixes are candidates for the first patch. That is why I didn't hurry to backport them sooner. |
|
Hi @surayya-MS. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
# [release 8.0] Fix radio button reset after submitting enhanced form Manual backport of #51796 ## Description This PR fixes resetting radio button checked property after submitting an enhanced form. ```html <form data-enhance> <input type="radio" /> <button>Submit</button> </form> ``` Workaround is to remove `data-enhance` attribute. Fixes #51429 ## Customer Impact Without this change customers will have bad experience using enhanced form that contains radio button. Radio button won't get reset after submitting the form. ## Regression? - [ ] Yes - [x] No [If yes, specify the version the behavior has regressed from] ## Risk - [ ] High - [ ] Medium - [x] Low This is a minor change. We have similar logic for checkbox approved #50991. There are unit and e2e tests for this change. ## Verification - [x] Manual (required) - [x] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props Fixes #51429
# [release 8.0] Fix radio button reset after submitting enhanced form Manual backport of dotnet/aspnetcore#51796 ## Description This PR fixes resetting radio button checked property after submitting an enhanced form. ```html <form data-enhance> <input type="radio" /> <button>Submit</button> </form> ``` Workaround is to remove `data-enhance` attribute. Fixes #51429 ## Customer Impact Without this change customers will have bad experience using enhanced form that contains radio button. Radio button won't get reset after submitting the form. ## Regression? - [ ] Yes - [x] No [If yes, specify the version the behavior has regressed from] ## Risk - [ ] High - [ ] Medium - [x] Low This is a minor change. We have similar logic for checkbox approved dotnet/aspnetcore#50991. There are unit and e2e tests for this change. ## Verification - [x] Manual (required) - [x] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props Fixes #51429
Fix radio button reset after submitting enhanced form
Description
This PR fixes resetting radio button checked property after submitting an enhanced form.
Workaround is to remove
data-enhanceattribute.Fixes #51429
Customer Impact
Without this change customers will have bad experience using enhanced form that contains radio button. Radio button won't get reset after submitting the form.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
This is a minor change. We have similar logic for checkbox approved #50991. There are unit and e2e tests for this change.
Verification
Packaging changes reviewed?
When servicing release/2.1