[release/8.0] Remove InvariantGlobalization in templates (#52428)

[eerhardt]

These entries were missed in #48238. InvariantGlobalization should only be set when the template is created for native AOT. That is the way it is for the worker and grpc templates already. These templates don't support AOT.

Fix #52319

Customer Impact

When creating a .NET 8 Web API project, InvariantGlobalization=true is being set. When using the SQL Client library in an app with InvariantGlobalization enabled, it fails because SQL Client doesn't support invariant globalization. See dotnet/SqlClient#220.

Regression?

• Yes
• No

Sort of a regression. It doesn't break existing projects, but new projects created with the latest template will break when using the SQL Client library.

Risk

• High
• Medium
• Low

This setting isn't enabled in our other, non-AOT templates. It was only set originally for performance reasons.

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

Do the Project Templates need packaging changes? @wtgodbe @DamianEdwards?

[ghost]

Hi @eerhardt. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[ghost]

Hi @eerhardt. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

[DamianEdwards]

Should we update the template tests to check for this property not being present in the output?

[eerhardt]

Should we update the template tests to check for this property not being present in the output?

Do you think that's worth the effort? My initial hunch is that it isn't worth it, considering we don't check for a bunch of other properties that aren't there. And if someone would add the property back, they would probably just change the test.

[danmoseley]

@eerhardt please mail tactics for approval when you're ready.

[eerhardt]

@eerhardt please mail tactics for approval when you're ready.

I already did on Nov 30. Steve already approved via email.

[ghost]

Hi @eerhardt. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

[ghost]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

[eerhardt]

@wtgodbe - any idea when this can be merged?

[wtgodbe]

any idea when this can be merged?

Branches will open for Feb servicing in early January (after the first Tuesday of the month)