Conversation
ghost
added
the
javiercn
requested review from
a team,
BrennanConroy and
halter73
as code owners
javiercn
force-pushed
the
javiercn/net90-enable-websocket-compression-blazor-server-web
branch
from
98298e4 to
e1b6ad1
Compare
Member
Author
|
Discussed offline, we have reached the conclusion that it is reasonable to restrict the framing to |
MackinnonBuck
approved these changes
Jan 27, 2024
Member
MackinnonBuck
left a comment
MackinnonBuck
left a comment
There was a problem hiding this comment.
Looks good to me, just some thoughts about the API and little nits here and there.
javiercn
force-pushed
the
javiercn/net90-enable-websocket-compression-blazor-server-web
branch
from
0d232ed to
03f1079
Compare
javiercn
dismissed
BrennanConroy’s stale review
I've removed the signalr bits, and handled the setup internally to Blazor as we spoke
javiercn
deleted the
javiercn/net90-enable-websocket-compression-blazor-server-web
branch
onurmicoogullari
pushed a commit
to onurmicoogullari/aspnetcore
that referenced
this pull request
Feb 14, 2024
…ve Server components in Blazor web (dotnet#53389) * Enables websocket compression by default on interactive server components. * A new overload of `AddServerRenderMode` allows configuring the compression parameters as well as disabling it by setting the websocket callback to `null`. * The `ContentSecurityAncestorPolicy` limits the ability to render the app/page inside an iframe from different origins. It can be disabled by setting the value to null (for example, if the policy is configured elsewhere) or restricted even further providing the value 'none', to constrain the policy even further.
This was referenced Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35897 and is part of #38127
Enables websocket compression for interactive server components
frame-ancestors: 'none'policy to block embedding the app inside an iframe when compression is enabled or a configuration for the websocket context has been provided.#53640 <- Docs issue for the security considerations