Removing noReload argument from WebDriverExtensions.Nagivate#55143
Merged
SteveSandersonMS merged 6 commits intodotnet:mainfrom Apr 22, 2024
Merged
Removing noReload argument from WebDriverExtensions.Nagivate#55143SteveSandersonMS merged 6 commits intodotnet:mainfrom
SteveSandersonMS merged 6 commits intodotnet:mainfrom
Conversation
…Navigate which directly calls WebDriverExtensions.Navigate
ghost
added
the
dotnet-policy-service
Bot
added
the
community-contribution
MattyLeslie
changed the title
Contributor
Author
|
@SteveSandersonMS May I request a review for this please. Thanks in advance. |
SteveSandersonMS
approved these changes
Apr 22, 2024
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Excellent - thanks very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing noReload Argument from WebDriverExtensions.Navigate
Summary of Changes:
This pull request addresses the removal of the noReload argument from the WebDriverExtensions.Navigate method. The removal was initiated in #35414, but the argument persisted. This PR rectifies this by eliminating the argument and adjusting all references throughout the tests accordingly.
Description:
Fixes:
This resolves issue #46810 by completely removing the noReload argument and updating all previous instances where it was utilized.