Remove AccountLayout.razor from project template#55294
Merged
Conversation
ghost
added
the
SteveSandersonMS
approved these changes
Apr 23, 2024
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
The change looks very neat.
I can't predict just by reading it whether it still works correctly (since auth may have other special requirements) but assuming it does, great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #55157, the
AccountLayoutfrom the Blazor Web project template should no longer be necessary. It didn't add any UI. Instead, it just checked if the component was rendering in interactive mode, and if so, calledNavigationManager.Refresh(forceReload: true)and showed<p>Loading...</p>in the meantime.The
ManageLayout.razorwhich renders an account management submenu remains.