Add WebAssemblyHotReloadCapabilities msbuild property#59094
Closed
tmat wants to merge 1 commit intodotnet:release/9.0from
Closed
Add WebAssemblyHotReloadCapabilities msbuild property#59094tmat wants to merge 1 commit intodotnet:release/9.0from
tmat wants to merge 1 commit intodotnet:release/9.0from
Conversation
Enables Hot Reload to detect capabilities before WASM runtime is loaded into the browser.
ghost
added
the
Member
Author
|
@MackinnonBuck @javiercn ptal |
javiercn
approved these changes
Nov 21, 2024
MackinnonBuck
approved these changes
Nov 21, 2024
Member
|
@tmat can you ask tactics for approval on this one? |
dotnet-policy-service
Bot
added
the
pending-ci-rerun
Member
|
Is this still needed? |
Member
Author
|
Yes, although it's currently unclear which branch it should go to. |
tmat
requested review from
a team,
BrennanConroy,
JamesNK,
captainsafia,
halter73,
mgravell and
wtgodbe
as code owners
Member
|
@tmat is this needed in the 9.0 release? |
Member
Author
|
We can move it to main. |
maraf
reviewed
Mar 7, 2025
| <PropertyGroup> | ||
| <BlazorWebAssemblyJSPath>$(MSBuildThisFileDirectory)blazor.webassembly.js</BlazorWebAssemblyJSPath> | ||
| <BlazorRoutingEnableRegexConstraint Condition="'$(BlazorRoutingEnableRegexConstraint)' == ''">false</BlazorRoutingEnableRegexConstraint> | ||
| <WebAssemblyHotReloadCapabilities>Baseline;AddMethodToExistingType;AddStaticFieldToExistingType;NewTypeDefinition;ChangeCustomAttributes;AddInstanceFieldToExistingType;GenericAddMethodToExistingType;GenericUpdateMethod;UpdateParameters;GenericAddFieldToExistingType</WebAssemblyHotReloadCapabilities> |
Member
There was a problem hiding this comment.
Shouldn't this go to the underlaying WebAssembly SDK? It's common to all ".NET in browser", not specific to Blazor, right?
Member
|
Resolved in dotnet/runtime#117747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Hot Reload to detect capabilities before WASM runtime is loaded into the browser.
Contributes to a fix of #59027