Remove setting IsStableBuild in Directory.Build.props#59310
Merged
akoeplinger merged 1 commit intomainfrom Dec 4, 2024
Merged
Conversation
It is a no-op. Arcade already sets this in https://github.com/dotnet/arcade/blob/7fff497cdf80039a4f2996699e5561e50812d948/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L55-L57 and as we discovered in #59309 the DotNetFinalVersionKind property isn't even set at that point.
ghost
added
the
area-infrastructure
ViktorHofer
approved these changes
Dec 4, 2024
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
It is a no-op. Arcade already sets this in https://github.com/dotnet/arcade/blob/7fff497cdf80039a4f2996699e5561e50812d948/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L55-L57 and as we discovered in #59309 the DotNetFinalVersionKind property isn't even set at that point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a no-op.
Arcade already sets this in https://github.com/dotnet/arcade/blob/7fff497cdf80039a4f2996699e5561e50812d948/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L55-L57 and as we discovered in #59309 the
DotNetFinalVersionKindproperty isn't even set at that point.