Update .NET SDK to 10.0.100-alpha.1.25067.4#59853
Conversation
Update .NET SDK to version 10.0.100-alpha.1.25063.8. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@carlossanlop @ViktorHofer looks like you guys have been touching APICompat over the past week or so, does this failure look familiar? dotnet/sdk#45807 |
I'll take a closer look at my change but it basically just made changes around logging. No other behaviors should've changed. |
|
Okay, one change we made was to stop logging CP1002, which is the error shown in this issue: - // Assembly loading ids
- public const string AssemblyReferenceNotFound = "CP1002";@ViktorHofer should we bring this back? That removal was part of the extra suggestions in the PR. |
|
Yes, the failure is from dotnet/sdk#45807 and need a reaction here. We intentionally made a breaking change as CP1002 warnings didn't make sense to include in the suppression file. I'll push a commit. |
Resolves the false positive warnings in dotnet/aspnetcore#59853
The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK.
|
I submitted dotnet/sdk#46059 to fix this in a better way. .NET Framework has a set of dangling internal only assemblies that should never get loaded. The PR is taking care of that so that our customers won't these false positives as well. Meanwhile, I pushed a commit to suppress the CP1002 diagnostics. |
|
Thanks! |
|
Needs another SDK update |
|
I don't understand why this new CP1002 is suddenly showing up. I will debug this offline. |
* Update .NET SDK Update .NET SDK to version 10.0.100-alpha.1.25063.8. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Suppress CP1002 temporarily via NoWarn The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK. * Remove NoWarns completely * Update SDK and dotnet tool versions * Update SDK and tools version in global.json * NoWarn CP1002 for MessagePack project --------- Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Updates the .NET SDK to version
10.0.100-alpha.1.25063.8, which also updates the .NET runtime from version10.0.0-alpha.1.25052.4to version10.0.0-alpha.1.25062.3.This pull request was auto-generated by GitHub Actions.