Changes in embedded dirs should also trigger templates testing#62806
Closed
ilonatommy wants to merge 3 commits intodotnet:mainfrom
Closed
Changes in embedded dirs should also trigger templates testing#62806ilonatommy wants to merge 3 commits intodotnet:mainfrom
ilonatommy wants to merge 3 commits intodotnet:mainfrom
Conversation
Member
Author
Member
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure DevOps pipeline trigger patterns to properly detect changes in deeply nested directories within the templates testing workflow. The change ensures that modifications to files embedded in subdirectories will trigger template tests, addressing an issue where a previous PR failed to trigger tests despite making changes in paths that should have been covered.
- Updated file matching patterns from single wildcard (*) to double wildcard (**) syntax
- Applied the change to three key source directories: ProjectTemplates, Components, and Mvc
wtgodbe
requested changes
Jul 18, 2025
Member
wtgodbe
left a comment
There was a problem hiding this comment.
The reason for this was that the templates pipeline wasn't classified in Product Catalog, so nothing was able to trigger it. Dnceng fixed that yesterday. The single * is actually the correct syntax - you can confirm by opening a PR today against a file in an embedded dir
Member
Member
Author
|
Thanks! |
This was referenced Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Follow up for #62752 (comment).
Description
PR #6275 did not trigger the template test, even though its change was under path listed in trigger mechanisms:
aspnetcore/.azure/pipelines/template-tests-pr.yml
Line 19 in 366296c
Investigating further, we need double wildcard there if we want changes to files embedded deeper in the structure to also trigger the job:
https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/file-matching-patterns?view=azure-devops