Provide code analysis rule to detect attribute routing for non-action methods#63657
Open
Alex-Sob wants to merge 3 commits intodotnet:mainfrom
Open
Provide code analysis rule to detect attribute routing for non-action methods#63657Alex-Sob wants to merge 3 commits intodotnet:mainfrom
Alex-Sob wants to merge 3 commits intodotnet:mainfrom
Conversation
Open
3 tasks
Contributor
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should address #56791
This PR is adding a new code analysis rule
ASP0029: Attribute routing is used for a method that is not an action. The diagnostic should be reported for a controller method if the following conditions are met:[NonAction]attribute.[Route]or[Http{Method}]or[AcceptVerbs]attributes.Changes
Modified
MvcAnalyzerso that it checks non-action methods of a controller to see if a method is marked with an attribute that implementsIRouteTemplateProvider. In such a case it reportsASP0029diagnostic.Added basic unit tests, I could add more if PR is accepted for review.