Skip to content

Conversation

@DeagleGross
Copy link
Member

@DeagleGross DeagleGross commented Dec 3, 2025

Updates to the infra to start building .net11

Copilot AI review requested due to automatic review settings December 3, 2025 11:17
@github-actions github-actions bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Dec 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@DeagleGross DeagleGross requested review from a team, JamesNK and tdykstra as code owners December 4, 2025 12:18
Copilot AI mentioned this pull request Dec 15, 2025
@dotnet dotnet deleted a comment from Copilot AI Dec 15, 2025
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 23, 2025
<configuration>
<packageSources>
<clear />
<add key="dotnet10" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11/nuget/v3/index.json" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<add key="dotnet10" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11/nuget/v3/index.json" />
<add key="dotnet11" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11/nuget/v3/index.json" />

<FrameworkReference Update="Microsoft.NETCore.App"
RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRefVersion)" />

<!-- Workaround when there is no vNext SDK available; copy known packs info from 9.0. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Workaround when there is no vNext SDK available; copy known packs info from 9.0. -->
<!-- Workaround when there is no vNext SDK available; copy known packs info from previous release -->

Condition=" '$(UpdateAspNetCoreKnownFramework)' == '' ">true</UpdateAspNetCoreKnownFramework>
</PropertyGroup>

<!-- Workaround when there is no vNext SDK available; copy known apphost/framework reference info from 9.0. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Workaround when there is no vNext SDK available; copy known apphost/framework reference info from 9.0. -->
<!-- Workaround when there is no vNext SDK available; copy known apphost/framework reference info from previous release -->

<!--
Reference base shared framework at incoming dependency flow version, not bundled sdk version.
Apply this to all projects that target the default tfm (e.g. net9.0) or a rid-based variant of it (e.g. net9.0-windows)
Apply this to all projects that target the default tfm (e.g. net10.0) or a rid-based variant of it (e.g. net10.0-windows)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this one generic so we don't need to constantly update it:

Suggested change
Apply this to all projects that target the default tfm (e.g. net10.0) or a rid-based variant of it (e.g. net10.0-windows)
Apply this to all projects that target the default tfm (e.g. netXX.0) or a rid-based variant of it (e.g. netXX.0-windows)

@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- Use fixed version instead of $(DefaultNetCoreTargetFramework) to avoid needing workarounds set up here. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this comment if it no longer applies?

"symbols/UseLocalDB/description": "Следует ли использовать LocalDB вместо SQLite. Этот параметр применяется, только если указывается --auth Individual или --auth IndividualB2C.",
"symbols/Framework/description": "Целевая платформа для проекта.",
"symbols/Framework/choices/net10.0/description": "Целевая платформа .NET 10.0",
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 10.0",
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 11.0",

"symbols/iisHttpsPort/description": "Номер порта, используемый для конечной точки HTTPS IIS Express в launchSettings.json.",
"symbols/Framework/description": "Целевая платформа для проекта.",
"symbols/Framework/choices/net10.0/description": "Целевая платформа .NET 10.0",
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 10.0",
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 11.0",

"symbols/iisHttpPort/description": "Номер порта, используемый для конечной точки HTTP IIS Express в launchSettings.json.",
"symbols/Framework/description": "Целевая платформа для проекта.",
"symbols/Framework/choices/net10.0/description": "Целевая платформа .NET 10.0",
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 10.0",
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 11.0",

"symbols/ExcludeLaunchSettings/description": "Следует ли исключить launchSettings.json из созданного шаблона.",
"symbols/Framework/description": "Целевая платформа для проекта.",
"symbols/Framework/choices/net10.0/description": "Целевая платформа .NET 10.0",
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 10.0",
"symbols/Framework/choices/net11.0/description": "Целевая платформа .NET 11.0",

<Import Project="Version.Details.props" />

<PropertyGroup Label="Version settings">
<AspNetCoreMajorVersion>10</AspNetCoreMajorVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we bump this as well in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, didn't see that this PR wasn't merged with main recently, we already bumped this in main

@wtgodbe
Copy link
Member

wtgodbe commented Jan 6, 2026

Closing in favor of the work being done in the VMR

@wtgodbe wtgodbe closed this Jan 6, 2026
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants