Skip to content

Conversation

@adityamandaleeka
Copy link
Member

Add actionable guidance to EndPointHttp2NotNegotiated error message, mentioning ALPN negotiation and suggesting either fixing the client configuration or enabling HTTP/1.1 as a fallback.

Fix #44241

Copilot AI review requested due to automatic review settings January 6, 2026 23:58
@github-actions github-actions bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the error message for HTTP/2 ALPN negotiation failures in Kestrel to provide more actionable guidance to developers. The update addresses issue #44241 by helping users understand what went wrong and how to resolve the issue.

Key Changes

  • Updated the EndPointHttp2NotNegotiated error message to explain the ALPN negotiation requirement and suggest two remediation options
  • Minor whitespace cleanup in XML comments (trailing spaces removed)

@adityamandaleeka adityamandaleeka enabled auto-merge (squash) January 7, 2026 00:22
@JamesNK
Copy link
Member

JamesNK commented Jan 7, 2026

Would it be useful to have an aka.ms link here that links to our docs with more information?

@adityamandaleeka
Copy link
Member Author

I'm not sure we have an existing page that is well-suited for this error. If we make one later we can add a link here, but for now I don't think it's worth blocking this PR for. Only 1 of the other 200-ish error messages in this file has a link in it and there's not much signal to indicate that this specific one is extra special... this change is just making the error message a bit more helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error","messageTemplate":"HTTP/2 over TLS was not negotiated on an HTTP/2-only endpoint.

3 participants