Add Name parameter to UserPasskeyInfo constructor#65815
Add Name parameter to UserPasskeyInfo constructor#65815BloodShop wants to merge 6 commits intodotnet:mainfrom
Conversation
UserPasskeyInfo exposes a Name property but the constructor doesn't accept it, forcing callers to use an object initializer to set it. Every other property is covered by the constructor, so the omission feels unintentional. This adds a new constructor overload that accepts an optional 'string? name' parameter. The existing constructor is preserved (it delegates to the new one with name: null) so there's no binary or source breaking change. Changes: - New constructor overload on UserPasskeyInfo with trailing 'name' parameter - Existing constructor chains into the new one - PublicAPI.Unshipped.txt updated - Unit tests for both constructors Fixes dotnet#65774
|
Thanks for your PR, @@BloodShop. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree |
CI Failure Analysis - Flaky Test IssueThe current CI failure is unrelated to this PR's code changes: Failed Test: Evidence this is a known flaky test:
Files changed in this PR:
Request: Please consider re-running CI or merging despite the flaky test, as this follows the established precedent of PR #65897 which had identical infrastructure failures. The code changes are solid and well-tested - this is purely an infrastructure timing issue. |
CI Status Update (March 26, 2026)All CI failures on this PR are infrastructure flaky tests unrelated to our changes. Here is the evidence: ✅ What Passes (all green)
❌ What Fails (random Helix tests)Latest run (build 1353428): 🔍 Key Evidence
🙏 RequestCould a maintainer please use |
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Summary
UserPasskeyInfoexposes aNameproperty but the constructor doesn't accept it — it's the only property left out. Callers have to fall back to an object initializer:This adds a constructor overload so
Namecan be set inline with everything else.What changed
UserPasskeyInfogets a second constructor with an additional trailingstring? nameparameter. The original constructor delegates to it withname: null, so nothing breaks — existing call sites compile and behave exactly as before.UserPasskeyInfo.cs..., byte[] clientDataJson, string? name): this(..., name: null)PublicAPI.Unshipped.txtUserPasskeyInfoTest.cs(new file)NamenullleavesNameunsetNamenullUsage
Breaking changes
None. The existing constructor signature is untouched and remains in
PublicAPI.Shipped.txt. The new overload is additive only.Fixes #65774