-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Virtualization] Visible content does not shift when in-DOM items above the viewport change height #65951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+481
−16
Merged
[Virtualization] Visible content does not shift when in-DOM items above the viewport change height #65951
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0827693
Viewport is anchored and DOM updates do not make it jump.
ilonatommy b0b224c
FIx compensation close to the viewport boundary.
ilonatommy 3c052b3
Merge remote-tracking branch 'origin/main' into viewport-anchoring
ilonatommy 38be1d9
Fix gramma.
ilonatommy f9b4ce8
Remove offsetHeight pre-seed from anchoredItems to avoid phantom scro…
ilonatommy 44fc396
Native anchoring with fallback.
ilonatommy 7907cc8
Tests.
ilonatommy 31dd0af
Remove redundant comments.
ilonatommy 40d5c63
Prepended items over viewport do not move it if we operate in-memory.
ilonatommy a1c9e4f
Convergence should not fight with anchoring.
ilonatommy b00d7ee
Missing change for previous commit: fighting can also happen for manu…
ilonatommy e46c5a3
More diagnostics to investigate CI failures that cannot be reproduced…
ilonatommy 52d6667
Stateful approach + diagnostics.
ilonatommy fd6b423
Fix + diagnostics.
ilonatommy d17061d
Tmp fix.
ilonatommy 5e41e68
Initial cleanup.
ilonatommy dd6e3cd
Deeper cleanup.
ilonatommy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.