Fix test-quarantine workflow's placeholder issue number behavior#66129
Merged
Fix test-quarantine workflow's placeholder issue number behavior#66129
Conversation
github-actions
Bot
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test-quarantine workflow instructions to prevent the agent from using placeholder issue identifiers (e.g., TODO) in [QuarantinedTest] attributes, which can lead to incorrect quarantining metadata and premature unquarantining decisions.
Changes:
- Adds explicit rules requiring
[QuarantinedTest]to reference a real GitHub issue URL with a numeric issue number. - Adds guidance to skip unquarantine eligibility checks for tests whose quarantine attribute still contains a non-numeric placeholder.
- Clarifies the PR creation step to prohibit placeholder text and require verifying the issue URL before committing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow sometimes uses placeholders for quarantine issue numbers, which can lead to "TODO" strings in the quarantine attribute: b0ccb07. Or worse, premature unquarantining (
RequestHeaderStringReuse_MultipleStreams_KnownHeaderReusedin #66083). Adding more explicit instructions about issue numbers should mitigate the bad behavior.