Fix re-quarantine criteria to only count post-unquarantine failures#66174
Merged
Fix re-quarantine criteria to only count post-unquarantine failures#66174
Conversation
The Case B re-quarantine logic was counting failures from before the unquarantine commit was merged. This led to tests being unnecessarily re-quarantined based on stale failure data (e.g., PR #66148 re-quarantined tests based on a failure from March 18, but the unquarantine PR #66072 wasn't merged until March 30). Updated to explicitly require that only failures occurring after the unquarantine merge date are considered. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “Daily Test Quarantine Management” documentation to prevent re-quarantine decisions from counting stale failures that occurred before a test was unquarantined.
Changes:
- Tightens Case B re-quarantine criteria to only count failures occurring after the unquarantine change was merged.
- Reframes and highlights “class-level quarantine” guidance as applying to both Case A and Case B.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Case B re-quarantine logic was counting failures from before the unquarantine commit was merged. This led to tests being unnecessarily re-quarantined based on stale failure data (e.g., PR #66148 re-quarantined tests based on a failure from March 18, but the unquarantine PR #66072 wasn't merged until March 30).
Updated to explicitly require that only failures occurring after the unquarantine merge date are considered.