Skip tests previously rejected for quarantine/unquarantine#66284
Merged
Skip tests previously rejected for quarantine/unquarantine#66284
Conversation
Check closed (not merged) [test-quarantine] PRs from the past 30 days before creating new quarantine/unquarantine PRs. If a previous PR for the same test was closed by a repo member with a comment explaining why (e.g., test wasn't actually flaky, fix was merged), skip that test for the current run. Motivated by PR #66283 where a quarantine PR was closed because the test failure was a real bug that had already been fixed, not a flaky test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Daily Test Quarantine Management workflow guidance so that tests are skipped if they were previously part of a recently closed (unmerged) [test-quarantine] PR that a human closed with a substantive explanation.
Changes:
- Adds an instruction to check recently closed (not merged)
[test-quarantine]PRs (last 30 days) for the same test before creating new quarantine/unquarantine PRs. - Codifies the rule in the “Important Rules” section, including the requirement for a substantive justification comment.
Use explicit author_association values (OWNER, MEMBER, COLLABORATOR, CONTRIBUTOR) instead of vague 'repository member or contributor' wording. CONTRIBUTOR is needed because github-actions[bot] (which runs the quarantine workflow) has that association value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the daily test quarantine workflow opens a quarantine PR and a human engineer closes it (without merging) with a comment explaining why the test shouldn't be quarantined, the workflow should respect that decision and not re-open a PR for the same test for the next 30 days.
Motivated by #66283, where @javiercn closed a quarantine PR because the test failure was a real bug that had already been fixed, not a flaky test.
Changes
Adds a new rule to the test-quarantine workflow prompt:
[test-quarantine]PRs from the past 30 days that targeted the same test