Cleanup ValidatableInfoResolverTests#66379
Merged
Youssef1313 merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
The tests in this class used to set up a mock and asserts it, essentially testing zero production code and only asserts that the moq library works. They serve no value. So deleting them
github-actions
Bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes several ValidatableInfoResolverTests that were only validating Moq setup behavior (rather than exercising production logic), leaving the remaining test that validates resolver-chain behavior through AddValidation / ValidationOptions.
Changes:
- Deleted Moq-only tests for
TryGetValidatableTypeInfoandTryGetValidatableParameterInfo. - Removed now-unused local test helper types that only supported the deleted tests.
BrennanConroy
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests in this class used to set up a mock and asserts it, essentially testing zero production code and only asserts that the moq library works. They serve no value. So deleting them