Remove mention of build-ops from ResourceManagement comments#66419
Remove mention of build-ops from ResourceManagement comments#66419
Conversation
github-actions
Bot
added
the
area-infrastructure
There was a problem hiding this comment.
Pull request overview
Updates the repository’s issue/PR automation policy to remove “build-ops” wording from dependency PR idle reminders, keeping automated messaging aligned with current team expectations.
Changes:
- Updated two auto-reply messages to remove “if you are on build-ops”.
- (Incidental) Reflowed a small YAML block in milestone assignment rules without changing intended structure.
| actions: | ||
| - addReply: | ||
| reply: This dependency PR has had no activity for a full business day - @dotnet/aspnet-build please take a look if you are on build-ops. | ||
| reply: This dependency PR has had no activity for a full business day - @dotnet/aspnet-build please take a look. |
There was a problem hiding this comment.
The weekend variant of this rule triggers after noActivitySince: days: 3, but the reply text still says "no activity for a full business day". Consider making the message match the configured threshold (e.g., reference 3 days / weekend), or reword it more generically ("no activity recently").
| reply: This dependency PR has had no activity for a full business day - @dotnet/aspnet-build please take a look. | |
| reply: This dependency PR has had no activity for 3 days over the weekend - @dotnet/aspnet-build please take a look. |
| - if: | ||
| - payloadType: Pull_Request | ||
| - isAction: | ||
| action: Closed | ||
| - targetsBranch: | ||
| branch: main | ||
| then: | ||
| - addMilestone: | ||
| milestone: 11.0-preview4 | ||
| - targetsBranch: | ||
| branch: main | ||
| then: | ||
| - addMilestone: | ||
| milestone: 11.0-preview4 | ||
| description: '[Milestone Assignments] Assign Milestone to PRs merged to the `main` branch' |
There was a problem hiding this comment.
These milestone assignment tasks match action: Closed and a base branch, but the description says "merged". Closing an unmerged PR also fires the closed action, so either add a filter that requires the PR to be merged (if supported by this policy schema) or update the description to reflect that it applies to all closed PRs targeting main.
| - if: | ||
| - payloadType: Pull_Request | ||
| - isAction: | ||
| action: Closed | ||
| - targetsBranch: | ||
| branch: release/11.0-preview3 | ||
| then: | ||
| - removeMilestone | ||
| - addMilestone: | ||
| milestone: 11.0-preview3 | ||
| - targetsBranch: | ||
| branch: release/11.0-preview3 | ||
| then: | ||
| - removeMilestone | ||
| - addMilestone: | ||
| milestone: 11.0-preview3 | ||
| description: '[Milestone Assignments] Assign Milestone to PRs merged to release/11.0-preview3 branch' |
There was a problem hiding this comment.
Same concern as the main branch rule: this uses action: Closed + targetsBranch but the description implies "merged" behavior. Consider requiring a merged PR (if supported), otherwise the automation will run for PRs that are simply closed without merging into release/11.0-preview3.
No description provided.