Make DefaultActionDescriptorCollectionProvider implement IDisposable#66426
Open
kvantetore wants to merge 2 commits intodotnet:mainfrom
Open
Make DefaultActionDescriptorCollectionProvider implement IDisposable#66426kvantetore wants to merge 2 commits intodotnet:mainfrom
kvantetore wants to merge 2 commits intodotnet:mainfrom
Conversation
…and disconnect from the supplied actionDescriptorChangeProviders when disposed
github-actions
Bot
added
the
area-mvc
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @kvantetore. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
|
@dotnet-policy-service agree company="Norbits" |
1 similar comment
Author
|
@dotnet-policy-service agree company="Norbits" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make DefaultActionDescriptorCollectionProvider implement IDisposable
Make DefaultActionDescriptorCollectionProvider implement IDisposable and disconnect from the supplied actionDescriptorChangeProviders when disposed.
Description
The fix follows the implementation of ActionEndpointDataSourceBase, and is fairly straight forward. I have updated the tests where it makes sense to dispose of the DefaultActionDescriptorCollectionProvider directly. However, I don't think it's important to do the disposing in the tests, so this could possibly be dropped.
Fixes #66425