Avoid unnecessary stackalloc in DataProtection#66428
Merged
BrennanConroy merged 2 commits intomainfrom Apr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CNG CBC+HMAC authenticated encryptor to avoid allocating a stack buffer for “size query” encryption operations by reusing the caller-provided plaintext buffer, along with minor related cleanup.
Changes:
- Refactors encrypted-size calculation to take the plaintext
ArraySegment<byte>rather than just a length. - Updates the padding/output-size query helper to use the plaintext segment instead of
stackalloc’d dummy input.
Youssef1313
reviewed
Apr 23, 2026
Youssef1313
reviewed
Apr 23, 2026
DeagleGross
approved these changes
Apr 23, 2026
This was referenced Apr 24, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stackalloc isn't needed since we already have an array of the correct size (the one the user passed in).
Also does some minor cleanup of the code.