Add test for ApiConventionAnalyzer when passing null to Created#66437
Merged
Youssef1313 merged 1 commit intomainfrom Apr 23, 2026
Merged
Add test for ApiConventionAnalyzer when passing null to Created#66437Youssef1313 merged 1 commit intomainfrom
Youssef1313 merged 1 commit intomainfrom
Conversation
github-actions
Bot
added
the
area-mvc
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage for issue #35277 to ensure ApiConventionAnalyzer does not crash when ControllerBase.Created(..., null) is used.
Changes:
- Added an integration test that runs the analyzer on a controller action returning
Created(uri, null)and asserts diagnostics are produced (indirectly also asserting no AD0001 analyzer crash). - Normalized file header encoding (BOM removal) in two files without functional changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Mvc/Mvc.Api.Analyzers/test/ApiConventionAnalyzerIntegrationTest.cs | Adds a new integration test covering Created(..., null) analyzer behavior/regression. |
| src/Mvc/Mvc.Api.Analyzers/src/SymbolApiResponseMetadataProvider.cs | No functional change; header/encoding normalization only. |
wtgodbe
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for #35277
Closes #35277