Update ProjectToExclude paths in Build.props for MVC benchmarks#66444
Merged
BrennanConroy merged 7 commits intomainfrom Apr 24, 2026
Merged
Update ProjectToExclude paths in Build.props for MVC benchmarks#66444BrennanConroy merged 7 commits intomainfrom
BrennanConroy merged 7 commits intomainfrom
Conversation
github-actions
Bot
added
the
area-infrastructure
wtgodbe
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the build-time project exclusion list to more precisely exclude MVC benchmark apps (that use PackageReference) instead of excluding all MVC perf projects, keeping the repo build project list accurate for current perf/benchmark layout.
Changes:
- Narrowed MVC perf exclusions from
src\Mvc\perf\**\*.csprojtosrc\Mvc\perf\benchmarkapps\**\*.csproj. - Removed an exclusion entry for
src\Servers\Kestrel\perf\PlatformBenchmarks\**\*.csproj(no longer present/needed).
Comment on lines
51
to
55
| <!-- Exclude the benchmarks because they use <PackageReference>. --> | ||
| <ProjectToExclude Include=" | ||
| $(RepoRoot)src\Components\benchmarkapps\BlazingPizza.Server\**\*.csproj; | ||
| $(RepoRoot)src\Mvc\perf\**\*.csproj; | ||
| $(RepoRoot)src\Servers\Kestrel\perf\PlatformBenchmarks\**\*.csproj; | ||
| $(RepoRoot)src\Mvc\perf\benchmarkapps\**\*.csproj; | ||
| $(RepoRoot)src\SignalR\perf\benchmarkapps\**\*.csproj; |
There was a problem hiding this comment.
The comment says “Exclude the benchmarks because they use ”, but this ItemGroup now excludes only the benchmarkapps (Mvc/SignalR) plus BlazingPizza. Consider updating the comment to clarify that it’s excluding benchmark apps/projects that use PackageReference, not all benchmarks (e.g., MVC microbenchmarks are no longer excluded).
wtgodbe
approved these changes
Apr 23, 2026
Removed workaround for dependency file generation.
DeagleGross
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.